for all one’s trouble

for (all) one's trouble

In exchange for the effort that one has made. Usually, the "reward" that such effort yields is negative. A: "But you've been so much better about getting to work on time!" B: "Yep, and all I got for my trouble was the boss criticizing my typing skills instead." And what did I get for all my trouble? A lousy commemorative pin.
See also: trouble
Farlex Dictionary of Idioms.

for (all) one’s trouble

phr. in spite of one’s efforts; in very poor payment for one’s efforts. He got a punch in the jaw for all his trouble.
See also: all, trouble
McGraw-Hill's Dictionary of American Slang and Colloquial Expressions
See also:
  • for (all) one's trouble
  • for one’s trouble
  • for trouble
  • begathon
  • go for the fences
  • make an effort (to do something)
  • spare no effort to (do something)
  • make every effort (to do something)
  • make every effort to do
  • an all-out effort